Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up rails integration #1150

Merged
merged 2 commits into from
Dec 16, 2020
Merged

Tidy up rails integration #1150

merged 2 commits into from
Dec 16, 2020

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Dec 16, 2020

This is to make different steps of integrations more understandable.

1. Give every patch/extension their own method to clarify their
   purposes.
2. Move most of the patches into after_initializer hook from their own
   initializers. This is for making the order of each step more
   understandable.
@st0012 st0012 added this to the 4.1.0 milestone Dec 16, 2020
@st0012 st0012 self-assigned this Dec 16, 2020
@codecov-io
Copy link

codecov-io commented Dec 16, 2020

Codecov Report

Merging #1150 (460ff62) into master (87c03f0) will increase coverage by 0.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1150      +/-   ##
==========================================
+ Coverage   97.76%   98.01%   +0.25%     
==========================================
  Files         188       28     -160     
  Lines        7867      706    -7161     
==========================================
- Hits         7691      692    -6999     
+ Misses        176       14     -162     
Impacted Files Coverage Δ
sentry-rails/lib/sentry/rails/railtie.rb 88.46% <100.00%> (+3.46%) ⬆️
sentry-raven/lib/raven/instance.rb
...-sidekiq/spec/sentry/sidekiq/error_handler_spec.rb
...en/spec/raven/integrations/rails/activejob_spec.rb
sentry-raven/spec/raven/integrations/rails_spec.rb
...-ruby/spec/sentry/transport/http_transport_spec.rb
...ations/rails/overrides/debug_exceptions_catcher.rb
sentry-ruby/lib/sentry/interfaces/request.rb
sentry-ruby/lib/sentry/rack/interface.rb
sentry-raven/lib/raven/logger.rb
... and 151 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87c03f0...460ff62. Read the comment docs.

@st0012 st0012 merged commit d5e616b into master Dec 16, 2020
@st0012 st0012 deleted the tidy-up-rails-integration branch December 16, 2020 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants