Add ThreadsInterface

sentry-ruby/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## Unreleased (4.2.0)
+
+- Add ThreadsInterface [#1178](https://github.com/getsentry/sentry-ruby/pull/1178)
+
 ## 4.1.4
 
 - Fix headers serialization for sentry-ruby [#1197](https://github.com/getsentry/sentry-ruby/pull/1197) (by @moofkit)

sentry-ruby/lib/sentry/client.rb

@@ -59,12 +59,15 @@ def event_from_exception(exception, hint = {})
 
       Event.new(configuration: configuration, integration_meta: integration_meta).tap do |event|
         event.add_exception_interface(exception)
+        event.add_threads_interface(crashed: true)
       end
     end
 
     def event_from_message(message, hint = {})
       integration_meta = Sentry.integrations[hint[:integration]]
-      Event.new(configuration: configuration, integration_meta: integration_meta, message: message)
+      event = Event.new(configuration: configuration, integration_meta: integration_meta, message: message)
+      event.add_threads_interface(backtrace: caller)
+      event
     end
 
     def event_from_transaction(transaction)

sentry-ruby/lib/sentry/event.rb

@@ -18,7 +18,7 @@ class Event
     )
 
     attr_accessor(*ATTRIBUTES)
-    attr_reader :configuration, :request, :exception, :stacktrace
+    attr_reader :configuration, :request, :exception, :stacktrace, :threads
 
     def initialize(configuration:, integration_meta: nil, message: nil)
       # this needs to go first because some setters rely on configuration
@@ -100,6 +100,7 @@ def to_hash
       data[:stacktrace] = stacktrace.to_hash if stacktrace
       data[:request] = request.to_hash if request
       data[:exception] = exception.to_hash if exception
+      data[:threads] = threads.to_hash if threads
 
       data
     end
@@ -112,6 +113,11 @@ def add_request_interface(env)
       @request = Sentry::RequestInterface.from_rack(env)
     end
 
+    def add_threads_interface(backtrace: nil, **options)
+      @threads = ThreadsInterface.new(**options)
+      @threads.stacktrace = initialize_stacktrace_interface(backtrace) if backtrace
+    end
+
     def add_exception_interface(exc)
       if exc.respond_to?(:sentry_context)
         @extra.merge!(exc.sentry_context)

sentry-ruby/lib/sentry/interface.rb

@@ -20,3 +20,4 @@ def to_hash
 require "sentry/interfaces/request"
 require "sentry/interfaces/single_exception"
 require "sentry/interfaces/stacktrace"
+require "sentry/interfaces/threads"

sentry-ruby/lib/sentry/interfaces/threads.rb

@@ -0,0 +1,26 @@
+module Sentry
+  class ThreadsInterface
+    attr_accessor :stacktrace
+
+    def initialize(crashed: false)
+      @id = Thread.current.object_id
+      @name = Thread.current.name
+      @current = true
+      @crashed = crashed
+    end
+
+    def to_hash
+      {
+        values: [
+          {
+            id: @id,
+            name: @name,
+            crashed: @crashed,
+            current: @current,
+            stacktrace: @stacktrace&.to_hash
+          }
+        ]
+      }
+    end
+  end
+end

sentry-ruby/spec/sentry/client_spec.rb

@@ -257,6 +257,24 @@ def sentry_context
       expect(hash[:message]).to eq(message)
       expect(hash[:level]).to eq(:error)
     end
+
+    it "inserts threads interface to the event" do
+      event = nil
+
+      t = Thread.new do
+        event = subject.event_from_message(message)
+      end
+
+      t.name = "Thread 1"
+      t.join
+      hash = event.to_hash
+
+      thread = hash[:threads][:values][0]
+      expect(thread[:id]).to eq(t.object_id)
+      expect(thread[:name]).to eq("Thread 1")
+      expect(thread[:crashed]).to eq(false)
+      expect(thread[:stacktrace]).not_to be_empty
+    end
   end
 
   describe "#event_from_transaction" do
@@ -296,6 +314,24 @@ def sentry_context
       expect(hash[:exception][:values][0][:value]).to eq(message)
     end
 
+    it "sets threads interface without stacktrace" do
+      event = nil
+
+      t = Thread.new do
+        event = subject.event_from_exception(exception)
+      end
+
+      t.name = "Thread 1"
+      t.join
+
+      thread = event.to_hash[:threads][:values][0]
+
+      expect(thread[:id]).to eq(t.object_id)
+      expect(thread[:name]).to eq("Thread 1")
+      expect(thread[:crashed]).to eq(true)
+      expect(thread[:stacktrace]).to be_nil
+    end
+
     it 'has level ERROR' do
       expect(hash[:level]).to eq(:error)
     end