Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DelayedJobAdapter from ignored list #1179

Merged
merged 1 commit into from
Jan 3, 2021

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Jan 3, 2021

That adapter should be appended from the sentry-delayed_job integration, not in sentry-rails.

That adapter should be appended from the sentry-delayed_job integration,
not here.
@st0012 st0012 added this to the 4.1.3 milestone Jan 3, 2021
@st0012 st0012 self-assigned this Jan 3, 2021
@codecov-io
Copy link

codecov-io commented Jan 3, 2021

Codecov Report

Merging #1179 (eb594b8) into master (84f1c35) will increase coverage by 0.95%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1179      +/-   ##
==========================================
+ Coverage   97.94%   98.89%   +0.95%     
==========================================
  Files         192       28     -164     
  Lines        8036      726    -7310     
==========================================
- Hits         7871      718    -7153     
+ Misses        165        8     -157     
Impacted Files Coverage Δ
sentry-rails/lib/sentry/rails/active_job.rb 100.00% <ø> (ø)
...ven/spec/raven/processors/removestacktrace_spec.rb
sentry-ruby/lib/sentry/interfaces/request.rb
...ntry-raven/lib/raven/core_ext/object/duplicable.rb
...try-raven/lib/sentry_raven_without_integrations.rb
...-raven/spec/raven/integrations/rails/event_spec.rb
...ry-raven/spec/raven/interfaces/stack_trace_spec.rb
...entry-sidekiq/lib/sentry/sidekiq/context_filter.rb
sentry-ruby/lib/sentry/dsn.rb
...ations/rails/overrides/debug_exceptions_catcher.rb
... and 155 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84f1c35...eb594b8. Read the comment docs.

@st0012 st0012 merged commit c8f49e8 into master Jan 3, 2021
@st0012 st0012 deleted the remove-delayed-job-from-ignored-adapters branch January 3, 2021 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants