Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out redundant event/payload from breadcrumbs logger #1222

Merged
merged 3 commits into from
Jan 21, 2021

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Jan 21, 2021

  • Removes potentially large payload from breadcrumbs. They're likely to make the event exceed size limit and be rejected by Sentry.
  • Ignores Rails' internal instrumentation events (names start with !)

@st0012 st0012 added this to the 4.1.5 milestone Jan 21, 2021
@st0012 st0012 self-assigned this Jan 21, 2021
@codecov-io
Copy link

codecov-io commented Jan 21, 2021

Codecov Report

Merging #1222 (5f202df) into master (40a63e7) will increase coverage by 0.89%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1222      +/-   ##
==========================================
+ Coverage   97.91%   98.80%   +0.89%     
==========================================
  Files         193       28     -165     
  Lines        8250      755    -7495     
==========================================
- Hits         8078      746    -7332     
+ Misses        172        9     -163     
Impacted Files Coverage Δ
...b/sentry/rails/breadcrumb/active_support_logger.rb 100.00% <100.00%> (ø)
...ec/sentry/rails/active_support_breadcrumbs_spec.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/breadcrumb.rb
sentry-raven/lib/raven/configuration.rb
sentry-ruby/spec/sentry/client_spec.rb
...ec/raven/processors/sanitizedata_processor_spec.rb
...ven/spec/raven/utils/exception_cause_chain_spec.rb
...try-ruby/lib/sentry/interfaces/single_exception.rb
...y-raven/lib/raven/integrations/rails/active_job.rb
sentry-raven/spec/raven/integrations/rake_spec.rb
... and 157 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40a63e7...5f202df. Read the comment docs.

@st0012 st0012 merged commit b83f871 into master Jan 21, 2021
@st0012 st0012 deleted the improve-breadcrumbs-logger branch January 21, 2021 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants