Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions with nil message shouldn't cause issues #1327

Merged
merged 2 commits into from
Mar 11, 2021
Merged

Exceptions with nil message shouldn't cause issues #1327

merged 2 commits into from
Mar 11, 2021

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Mar 11, 2021

closes #1323

@st0012 st0012 added this to the 4.3.0 milestone Mar 11, 2021
@st0012 st0012 self-assigned this Mar 11, 2021
@codecov-io
Copy link

codecov-io commented Mar 11, 2021

Codecov Report

Merging #1327 (c22932c) into master (7989855) will increase coverage by 0.62%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1327      +/-   ##
==========================================
+ Coverage   98.08%   98.70%   +0.62%     
==========================================
  Files         208      113      -95     
  Lines        9088     5260    -3828     
==========================================
- Hits         8914     5192    -3722     
+ Misses        174       68     -106     
Impacted Files Coverage Δ
...try-ruby/lib/sentry/interfaces/single_exception.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/hub_spec.rb 100.00% <100.00%> (ø)
sentry-rails/lib/sentry/rails/active_job.rb 96.87% <0.00%> (-0.10%) ⬇️
...-sidekiq/spec/sentry/sidekiq/error_handler_spec.rb 100.00% <0.00%> (ø)
...ven/breadcrumbs/active_support_breadcrumbs_spec.rb
...ry-raven/spec/raven/interfaces/stack_trace_spec.rb
...ven/spec/raven/utils/exception_cause_chain_spec.rb
sentry-raven/spec/raven/configuration_spec.rb
sentry-raven/lib/raven/integrations/delayed_job.rb
...ations/rails/overrides/debug_exceptions_catcher.rb
... and 89 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7989855...c22932c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants