A lot of improvements on formatting and syntax best practices #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: lib/raven.rb lib/raven/context.rb
| @@ -186,8 +189,8 @@ | |||
| }, | |||
| :server_name => 'foo.local', | |||
| :configuration => config | |||
| }).to_hash() | |||
| } | |||
| ).to_hash | |||
There was a problem hiding this comment.
I believe removing that explicit "{}" is causing a build failure on 1.8.7.
There was a problem hiding this comment.
Thanks, I'll check and fix that
|
I think most of these changes are OK - up to @dcramer if he thinks the obfuscation of git history due to this is worth it. |
|
Done! I also added mime-types as development dependency, because coveralls gem require rest-client that requires mime-types, and the latest version of it (2.x) doesn't support Ruby 1.8.7. It would be a good idea to add Gemfile.lock to git to prevent this kind of problems. |
|
+1 to merge now, again with the caveat of the effects on git history as mentioned above. This is a big change, so @dcramer ? |
|
@nateberkopec no objections here |
nateberkopec
added a commit
that referenced
this pull request
Dec 4, 2013
A lot of improvements on formatting and syntax best practices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used Rubocop to search for formatting and syntax warnings. There are still a lot of warnings left, like "Use the new Ruby 1.9 hash syntax", which I ignored because raven-ruby still supports Ruby 1.8.7, and "Cyclomatic complexity for to_hash is too high", which would require a bigger refactoring.