Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit breadcrumb's message length #1465

Merged
merged 2 commits into from
Jun 4, 2021
Merged

Limit breadcrumb's message length #1465

merged 2 commits into from
Jun 4, 2021

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Jun 4, 2021

Sentry::Event's message has a 8096 size limit, which should also be applied to breadcrumb's message to prevent useless and even harmful data.

This should partially fix #1422

@st0012 st0012 added this to the 4.5.1 milestone Jun 4, 2021
@st0012 st0012 self-assigned this Jun 4, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2021

Codecov Report

Merging #1465 (41dce08) into master (a72ddc7) will increase coverage by 0.59%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1465      +/-   ##
==========================================
+ Coverage   98.24%   98.84%   +0.59%     
==========================================
  Files         214      119      -95     
  Lines       10142     6316    -3826     
==========================================
- Hits         9964     6243    -3721     
+ Misses        178       73     -105     
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/breadcrumb.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/breadcrumb_spec.rb 100.00% <100.00%> (ø)
sentry-rails/app/jobs/sentry/send_event_job.rb 72.22% <0.00%> (-5.56%) ⬇️
sentry-rails/lib/sentry/rails/active_job.rb 97.05% <0.00%> (-0.09%) ⬇️
sentry-rails/lib/sentry/rails/configuration.rb 100.00% <0.00%> (ø)
...-sidekiq/spec/sentry/sidekiq/error_handler_spec.rb 100.00% <0.00%> (ø)
sentry-raven/lib/raven/transports/dummy.rb
sentry-raven/lib/raven/interfaces/message.rb
...y-raven/spec/raven/processors/http_headers_spec.rb
sentry-raven/spec/raven/json_spec.rb
... and 91 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a72ddc7...41dce08. Read the comment docs.

@st0012 st0012 merged commit 9c3d474 into master Jun 4, 2021
@st0012 st0012 deleted the fix-#1422 branch June 4, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mysql2::Error: MySQL client is not connected
2 participants