Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracing support to sentry-delayed_job #1482

Merged
merged 1 commit into from
Jun 25, 2021

Conversation

fsateler
Copy link
Contributor

Fixes #1312

@fsateler fsateler force-pushed the feature/delayed_job-performance branch from 2a009b1 to d0a1874 Compare June 24, 2021 16:44
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2021

Codecov Report

Merging #1482 (dcfeb63) into master (fac1db6) will increase coverage by 0.56%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1482      +/-   ##
==========================================
+ Coverage   98.20%   98.76%   +0.56%     
==========================================
  Files         218      123      -95     
  Lines       10467     6716    -3751     
==========================================
- Hits        10279     6633    -3646     
+ Misses        188       83     -105     
Impacted Files Coverage Δ
...entry-delayed_job/lib/sentry/delayed_job/plugin.rb 100.00% <100.00%> (ø)
sentry-delayed_job/spec/sentry/delayed_job_spec.rb 100.00% <100.00%> (ø)
sentry-rails/app/jobs/sentry/send_event_job.rb 72.22% <0.00%> (-5.56%) ⬇️
sentry-raven/spec/raven/interface_spec.rb
sentry-raven/lib/raven/interfaces/stack_trace.rb
...try-raven/lib/sentry-raven-without-integrations.rb
sentry-raven/lib/raven/utils/real_ip.rb
sentry-raven/lib/raven/transports/http.rb
sentry-raven/lib/raven/utils/context_filter.rb
.../lib/raven/integrations/rails/backtrace_cleaner.rb
... and 88 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fac1db6...dcfeb63. Read the comment docs.

Copy link
Collaborator

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey thanks a lot for adding this 👍
just left some comments for polishing. I think you also need to rebase the branch and resolve the conflict in order to start the build.

sentry-delayed_job/lib/sentry/delayed_job/plugin.rb Outdated Show resolved Hide resolved
sentry-delayed_job/lib/sentry/delayed_job/plugin.rb Outdated Show resolved Hide resolved
sentry-delayed_job/lib/sentry/delayed_job/plugin.rb Outdated Show resolved Hide resolved
sentry-delayed_job/lib/sentry/delayed_job/plugin.rb Outdated Show resolved Hide resolved
@fsateler fsateler force-pushed the feature/delayed_job-performance branch from 7df7aaa to dcfeb63 Compare June 25, 2021 15:32
@fsateler
Copy link
Contributor Author

Done!

Copy link
Collaborator

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this 😄

@st0012 st0012 merged commit 6aaa4c1 into getsentry:master Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support performance monitoring in sentry-delayed_job
3 participants