Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't start Sentry::SendEventJob's transaction #1547

Merged
merged 2 commits into from
Aug 22, 2021
Merged

Don't start Sentry::SendEventJob's transaction #1547

merged 2 commits into from
Aug 22, 2021

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Aug 22, 2021

Fixes #1539

@st0012 st0012 added this to the 4.7.0 milestone Aug 22, 2021
@st0012 st0012 self-assigned this Aug 22, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2021

Codecov Report

Merging #1547 (b4c3b05) into master (3ddb146) will increase coverage by 0.38%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1547      +/-   ##
==========================================
+ Coverage   97.89%   98.28%   +0.38%     
==========================================
  Files         222      127      -95     
  Lines       10838     7002    -3836     
==========================================
- Hits        10610     6882    -3728     
+ Misses        228      120     -108     
Impacted Files Coverage Δ
sentry-rails/app/jobs/sentry/send_event_job.rb 87.50% <ø> (+9.72%) ⬆️
sentry-rails/lib/sentry/rails/active_job.rb 97.36% <100.00%> (+0.22%) ⬆️
sentry-raven/lib/raven/utils/real_ip.rb
sentry-raven/lib/raven/transports/stdout.rb
...try-raven/lib/raven/utils/exception_cause_chain.rb
...ven/lib/raven/breadcrumbs/active_support_logger.rb
...entry-raven/lib/raven/breadcrumbs/sentry_logger.rb
sentry-raven/lib/raven/interfaces/http.rb
...y-raven/lib/raven/integrations/rails/active_job.rb
...-raven/spec/raven/integrations/rails/event_spec.rb
... and 87 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ddb146...b4c3b05. Read the comment docs.

@st0012 st0012 changed the title Don't event start Sentry::SendEventJob's transaction Don't even start Sentry::SendEventJob's transaction Aug 22, 2021
@st0012 st0012 changed the title Don't even start Sentry::SendEventJob's transaction Don't start Sentry::SendEventJob's transaction Aug 22, 2021
@st0012 st0012 merged commit 2cc4c21 into master Aug 22, 2021
@st0012 st0012 deleted the fix-#1539 branch August 22, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sentry-rails: NoMethodError: undefined method `span' for nil:NilClass
2 participants