Use nil instead of false to disable callable settings #1594
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
false
to disable settings doesn't match nowadays convention. So I'm changing the disabling value ofbefore_send
andasync
(both inherited fromsentry-raven
) fromfalse
tonil
.Since they are both disabled by default, most users shouldn't need to disable them manually anyway. So I think this change should have a minimum impact and can be shipped in a minor release.