Skip to content

Deprecate unnecessarily exposed attributes #1652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 25, 2021

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Dec 25, 2021

Although they probably aren't used by anyone, directly removing them can still break some users' apps. So I decide to remove them later in version 5.0.0.

@st0012 st0012 added this to the 4.9.0 milestone Dec 25, 2021
@st0012 st0012 self-assigned this Dec 25, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 25, 2021

Codecov Report

Merging #1652 (9f7275b) into master (fdf1771) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1652   +/-   ##
=======================================
  Coverage   98.46%   98.46%           
=======================================
  Files         135      135           
  Lines        7534     7542    +8     
=======================================
+ Hits         7418     7426    +8     
  Misses        116      116           
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/background_worker.rb 94.59% <100.00%> (+0.15%) ⬆️
sentry-ruby/lib/sentry/client.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/transaction.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/transport.rb 98.82% <100.00%> (+0.01%) ⬆️
sentry-ruby/lib/sentry/utils/logging_helper.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/transaction_spec.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry_spec.rb 99.74% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdf1771...9f7275b. Read the comment docs.

@st0012 st0012 requested a review from sl0thentr0py December 25, 2021 13:54
@st0012 st0012 merged commit 0483876 into master Dec 25, 2021
@st0012 st0012 deleted the deprecate-over-exposed-attributes branch December 25, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants