Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix context merging #1722 #1724

Merged
merged 2 commits into from
Feb 11, 2022
Merged

Fix context merging #1722 #1724

merged 2 commits into from
Feb 11, 2022

Conversation

thomasjachmann
Copy link
Contributor

When using the same key in a context hash, the new value should
overwrite the old value. Before, the value having been set first would
always win.

fixes #1722

When using the same key in a context hash, the new value should
overwrite the old value. Before, the value having been set first would
always win.

fixes #1722
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2022

Codecov Report

Merging #1724 (379d542) into master (c65088f) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1724      +/-   ##
==========================================
- Coverage   98.41%   98.38%   -0.03%     
==========================================
  Files         141      141              
  Lines        8004     8012       +8     
==========================================
+ Hits         7877     7883       +6     
- Misses        127      129       +2     
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/scope.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/scope/setters_spec.rb 97.36% <100.00%> (+0.19%) ⬆️
sentry-ruby/lib/sentry/background_worker.rb 94.59% <0.00%> (-5.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c65088f...379d542. Read the comment docs.

@st0012 st0012 added this to the 5.2.0 milestone Feb 11, 2022
Copy link
Collaborator

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's a bug. Thank you for reporting it and making the PR! 😄

@st0012 st0012 merged commit e960d02 into getsentry:master Feb 11, 2022
@thomasjachmann thomasjachmann deleted the fix-context-merging branch February 11, 2022 22:23
@rahul342
Copy link

Thank for you fixing! Curious, is there a timeline by which this goes live in new release?

@st0012 st0012 modified the milestones: 5.2.0, 5.1.1 Feb 20, 2022
@st0012
Copy link
Collaborator

st0012 commented Feb 20, 2022

This should go out with version 5.1.1 next week 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set_context doesn't allow to overwrite values
4 participants