-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check envelope size before sending it #1747
Conversation
@sl0thentr0py I know the code could still be refactored (which I'll do later), but can you give it a quick scan and see if the approach looks good? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic looks ok 👍
Codecov Report
@@ Coverage Diff @@
## master #1747 +/- ##
==========================================
+ Coverage 98.43% 98.45% +0.01%
==========================================
Files 144 144
Lines 8312 8412 +100
==========================================
+ Hits 8182 8282 +100
Misses 130 130
Continue to review full report at Codecov.
|
Because we now need to check if a serialized envelope item is oversized (see #1603 (comment)), envelope serialization is better performed by Transport to have more control to filter oversized items.
Transport#serialize_envelope
to control envelope serialization
Because we now need to check if a serialized envelope item is oversized (see #1603 (comment)), envelope serialization is better performed by Transport to have more control to filter oversized items.