Skip to content

Conversation

@st0012
Copy link
Contributor

@st0012 st0012 commented Apr 23, 2022

As mentioned in #1723 (comment), net-http spans should attach to the current span instead of always the top-level transaction.

@st0012 st0012 added this to the 5.3.0 milestone Apr 23, 2022
@st0012 st0012 self-assigned this Apr 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.42%. Comparing base (942f645) to head (dac0bc3).
⚠️ Report is 555 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1796      +/-   ##
==========================================
+ Coverage   98.41%   98.42%   +0.01%     
==========================================
  Files         145      145              
  Lines        8576     8588      +12     
==========================================
+ Hits         8440     8453      +13     
+ Misses        136      135       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@st0012 st0012 requested a review from sl0thentr0py April 23, 2022 11:15
@st0012 st0012 merged commit 07084c5 into master Apr 25, 2022
@st0012 st0012 deleted the fix-span-nesting branch April 25, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants