Add config.enable_tracing for easier performance tracing setup #2005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2005 +/- ##
=======================================
Coverage 98.56% 98.56%
=======================================
Files 157 157
Lines 10075 10105 +30
=======================================
+ Hits 9930 9960 +30
Misses 145 145
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
sl0thentr0py
force-pushed
the
neel/enable-tracing
branch
from
4fcb62f to
6cd676c
Compare
antonpirker
approved these changes
Feb 16, 2023
st0012
approved these changes
Feb 16, 2023
sl0thentr0py
force-pushed
the
neel/enable-tracing
branch
from
6cd676c to
fd7daad
Compare
|
master rails is broken :( I will fix later |
|
@sl0thentr0py After checking the error, it seems to be caused by Rails itself, see: rails/rails#47377. And there is already a PR for it: rails/rails#47409 So IMO we can wait a couple of days for the issue to be resolved upstream. |
The new optional boolean will set traces_sample_rate to 1.0 automatically if not set yet. If false, this will also disable tracing even if a sample rate or sampler is set.
sl0thentr0py
force-pushed
the
neel/enable-tracing
branch
from
fd7daad to
2bf8dca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new optional boolean will set traces_sample_rate to 1.0
automatically if not set yet. If false, this will also disable tracing
even if a sample rate or sampler is set.
closes #1996