Allow java exceptions as capture type in JRuby (#2043) #2044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for bothering, but could someone review this or leave a comment on further proceedings? @st0012, @sl0thentr0py you seem like the most active recent contributors. |
|
Sorry for the delay. Yeah I think the implementation is reasonable. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2044 +/- ##
==========================================
- Coverage 83.20% 83.19% -0.02%
==========================================
Files 119 119
Lines 5651 5653 +2
==========================================
+ Hits 4702 4703 +1
- Misses 949 950 +1
☔ View full report in Codecov by Sentry. |
|
Oh, I'm sorry. Seems, like I didn't notice my formatter formatting the whole file 🙈. Should be fixed now. |
richard-kramer
force-pushed
the
2043_allow_java_exceptions
branch
2 times, most recently
from
20106ad
to
a71c897
Compare
richard-kramer
force-pushed
the
2043_allow_java_exceptions
branch
from
a71c897
to
1072f40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the problems described in #2043. It should now be possible to directly capture exceptions originating in Java when running in JRuby.
I'm not entirely sure, if the implementation is clean enough, and am open for feedback. I based it on something similar in sentry/raven.