-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate HTTP span data conventions with OpenTelemetry #2093
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2093 +/- ##
==========================================
- Coverage 83.25% 83.25% -0.01%
==========================================
Files 119 119
Lines 5674 5679 +5
==========================================
+ Hits 4724 4728 +4
- Misses 950 951 +1
☔ View full report in Codecov by Sentry. |
33215d6
to
af7e658
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we did a span name change in #1923, some users reported that it "broke" their filtering logic and resulted in higher-than-expected usages. Since status code could be a common method for filtering, I'm a bit concerned that similar issue could happen again. Should we still set status_code
so users don't get breaking change in a minor version upgrade?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
af7e658
to
fd17ccf
Compare
@st0012 good point, but this is |
in preparation for some of our new performance UIs we're consolidating span data keys with OpenTelemetry with a new
Span::DataConventions
module.This PR handles the HTTP spans.
see getsentry/team-sdks#20