Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mention of renamed attribute #2251

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Fix mention of renamed attribute #2251

merged 1 commit into from
Feb 21, 2024

Conversation

c960657
Copy link
Contributor

@c960657 c960657 commented Feb 20, 2024

rails_report_rescued_exceptions was changed to rails.report_rescued_exceptions in #1070. The inline docuentation was copied without updating the attribute name.

Copy link
Collaborator

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thx 👍

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Merging #2251 (ce9d202) into master (7702905) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2251      +/-   ##
==========================================
+ Coverage   66.44%   66.47%   +0.02%     
==========================================
  Files         101      101              
  Lines        3797     3797              
==========================================
+ Hits         2523     2524       +1     
+ Misses       1274     1273       -1     
Components Coverage Δ
sentry-ruby 55.63% <ø> (ø)
sentry-rails 95.05% <ø> (ø)
sentry-sidekiq 94.70% <ø> (ø)
sentry-resque 92.30% <ø> (+1.53%) ⬆️
sentry-delayed_job 95.60% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
sentry-rails/lib/sentry/rails/configuration.rb 97.14% <ø> (ø)

... and 1 file with indirect coverage changes

@st0012 st0012 merged commit 27128d6 into getsentry:master Feb 21, 2024
95 of 122 checks passed
@c960657 c960657 deleted the patch-2 branch February 21, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants