-
-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add report_after_job_retries support for ActiveJob #2500
Draft
modosc
wants to merge
10
commits into
getsentry:master
Choose a base branch
from
treadinc:active-job-report_after_job_retries
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
add report_after_job_retries support for ActiveJob #2500
modosc
wants to merge
10
commits into
getsentry:master
from
treadinc:active-job-report_after_job_retries
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modosc
force-pushed
the
active-job-report_after_job_retries
branch
from
December 18, 2024 16:31
5ecd340
to
2be327a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2500 +/- ##
==========================================
- Coverage 98.19% 92.48% -5.72%
==========================================
Files 128 122 -6
Lines 4833 4713 -120
==========================================
- Hits 4746 4359 -387
- Misses 87 354 +267
|
modosc
force-pushed
the
active-job-report_after_job_retries
branch
from
December 18, 2024 16:39
79897d2
to
0ce620d
Compare
modosc
changed the title
add report_after_job_retries support for activejob
add report_after_job_retries support for ActiveJob
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this pr adds
report_after_job_retries
support toActiveJob
(configured viaconfig.rails.active_job_report_after_job_retries
).the easiest way to do this would have been to use retry_on in the base
ActiveJob
class (similar to here) but that's difficult to do properly which is (i think) why the currentActiveJob
integration doesn't do it.instead we can take advantage of the
retry_stopped.active_job
notification that's published when a job runs out of retries. this makes our setup a single call toActiveSupport::Notifications.subscribe
.fixes #2499