Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Metrics::Timing.duration_(start,end) #2501

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

solnic
Copy link
Collaborator

@solnic solnic commented Dec 19, 2024

This is just a quick follow-up after merging #2471

#skip-changelog

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.20%. Comparing base (bb9ce72) to head (fda0638).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2501      +/-   ##
==========================================
+ Coverage   98.17%   98.20%   +0.02%     
==========================================
  Files         128      128              
  Lines        4833     4837       +4     
==========================================
+ Hits         4745     4750       +5     
+ Misses         88       87       -1     
Components Coverage Δ
sentry-ruby 98.57% <100.00%> (+<0.01%) ⬆️
sentry-rails 97.07% <ø> (+0.15%) ⬆️
sentry-sidekiq 97.42% <ø> (ø)
sentry-resque 92.85% <ø> (ø)
sentry-delayed_job 95.65% <ø> (ø)
sentry-opentelemetry 99.31% <ø> (ø)
Files with missing lines Coverage Δ
sentry-ruby/lib/sentry/cron/monitor_check_ins.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/metrics/timing.rb 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@solnic solnic marked this pull request as ready for review December 19, 2024 07:49
@solnic solnic merged commit ad535cc into master Dec 19, 2024
137 of 138 checks passed
@solnic solnic deleted the solnic/duration-helper branch December 19, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants