Deprecate config.metrics and Sentry::Metrics

[sl0thentr0py]

No description provided.

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 71.74%. Comparing base (b5a4948) to head (5c96b67).

Files with missing lines	Patch %	Lines
sentry-ruby/lib/sentry/cron/monitor_check_ins.rb	0.00%	3 Missing ⚠️
sentry-ruby/lib/sentry/metrics.rb	25.00%	3 Missing ⚠️
sentry-ruby/lib/sentry/metrics/configuration.rb	80.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2539      +/-   ##
==========================================
+ Coverage   69.40%   71.74%   +2.33%     
==========================================
  Files         126      118       -8     
  Lines        4723     4427     -296     
==========================================
- Hits         3278     3176     -102     
+ Misses       1445     1251     -194     

Components	Coverage Δ
sentry-ruby	62.54% <50.00%> (+2.35%)	⬆️
sentry-rails	97.48% <ø> (ø)
sentry-sidekiq	95.52% <ø> (-0.38%)	⬇️
sentry-resque	92.64% <ø> (ø)
sentry-delayed_job	95.65% <ø> (ø)
sentry-opentelemetry	100.00% <ø> (ø)

Files with missing lines	Coverage Δ
sentry-ruby/lib/sentry-ruby.rb	68.49% <100.00%> (+0.78%)	⬆️
sentry-ruby/lib/sentry/configuration.rb	85.86% <100.00%> (ø)
sentry-ruby/lib/sentry/envelope/item.rb	46.93% <ø> (+12.93%)	⬆️
...y-ruby/lib/sentry/interfaces/stacktrace_builder.rb	100.00% <ø> (+8.82%)	⬆️
sentry-ruby/lib/sentry/span.rb	86.36% <ø> (+0.03%)	⬆️
sentry-ruby/lib/sentry/transaction_event.rb	80.55% <ø> (+1.60%)	⬆️
sentry-ruby/lib/sentry/metrics/configuration.rb	88.88% <80.00%> (+4.27%)	⬆️
sentry-ruby/lib/sentry/cron/monitor_check_ins.rb	28.94% <0.00%> (ø)
sentry-ruby/lib/sentry/metrics.rb	57.14% <25.00%> (-1.69%)	⬇️

... and 4 files with indirect coverage changes

[st0012]

I don't have much context on this so this is an unblocking opinion: we probably should include this directly in the 6.0 release and move the release of it forward. Removing APIs' functionality technically is still breaking change so we'd still be breaking semver if we release it before 6.0.

[sl0thentr0py]

Removing APIs' functionality technically is still breaking change

the server ignores these payloads completely anyway, so in that way it already 'broke'

but yeah, I also want to do the major soon but I do not have bandwidth to prepare it in the coming month or so

[solnic]

but yeah, I also want to do the major soon but I do not have bandwidth to prepare it in the coming month or so

@sl0thentr0py happy to help with this