Skip to content

Conversation

sl0thentr0py
Copy link
Member

Description

Relay already has an updated solution implemented in relay#3905 that handles the recursive case by trimming from both sides so this logic in the SDK is now redundant.

Issues

Copy link

linear bot commented Sep 23, 2025

@sl0thentr0py sl0thentr0py force-pushed the neel/simplify-truncation branch from 546112c to c776a86 Compare September 23, 2025 11:59
Copy link

codecov bot commented Sep 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.41%. Comparing base (6e39d31) to head (c776a86).
⚠️ Report is 1 commits behind head on 6.0-dev.

Additional details and impacted files
@@             Coverage Diff             @@
##           6.0-dev    #2714      +/-   ##
===========================================
- Coverage    97.43%   97.41%   -0.03%     
===========================================
  Files          143      143              
  Lines         5617     5605      -12     
===========================================
- Hits          5473     5460      -13     
- Misses         144      145       +1     
Components Coverage Δ
sentry-ruby 97.69% <ø> (-0.04%) ⬇️
sentry-rails 96.59% <ø> (ø)
sentry-sidekiq 96.57% <ø> (ø)
sentry-resque 94.44% <ø> (ø)
sentry-delayed_job 94.68% <ø> (ø)
sentry-opentelemetry 99.31% <ø> (ø)
Files with missing lines Coverage Δ
sentry-ruby/lib/sentry/envelope/item.rb 94.73% <ø> (-3.27%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sl0thentr0py sl0thentr0py requested a review from solnic September 23, 2025 12:13
Copy link
Collaborator

@solnic solnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The best types of PRs 🙃 ✅

@sl0thentr0py sl0thentr0py merged commit ed7a2db into 6.0-dev Sep 23, 2025
137 of 138 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/simplify-truncation branch September 23, 2025 12:16
@sl0thentr0py sl0thentr0py mentioned this pull request Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants