Skip to content

Conversation

sl0thentr0py
Copy link
Member

Copy link

linear bot commented Sep 23, 2025

@sl0thentr0py sl0thentr0py force-pushed the neel/enabled-environments-nil branch from 1dcba77 to 07d8d87 Compare September 23, 2025 12:54
Copy link

codecov bot commented Sep 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.41%. Comparing base (ed7a2db) to head (07d8d87).
⚠️ Report is 1 commits behind head on 6.0-dev.

Additional details and impacted files
@@             Coverage Diff             @@
##           6.0-dev    #2716      +/-   ##
===========================================
+ Coverage    95.83%   97.41%   +1.58%     
===========================================
  Files          141      143       +2     
  Lines         5494     5606     +112     
===========================================
+ Hits          5265     5461     +196     
+ Misses         229      145      -84     
Components Coverage Δ
sentry-ruby 97.69% <100.00%> (+0.47%) ⬆️
sentry-rails 96.59% <ø> (+8.32%) ⬆️
sentry-sidekiq 96.57% <ø> (ø)
sentry-resque 94.44% <ø> (ø)
sentry-delayed_job 94.68% <ø> (-0.98%) ⬇️
sentry-opentelemetry 99.31% <ø> (ø)
Files with missing lines Coverage Δ
sentry-ruby/lib/sentry/configuration.rb 98.40% <100.00%> (ø)
sentry-ruby/lib/sentry/test_helper.rb 96.15% <100.00%> (+0.07%) ⬆️

... and 47 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sl0thentr0py sl0thentr0py requested a review from solnic September 23, 2025 13:06

def enabled_in_current_env?
enabled_environments.empty? || enabled_environments.include?(environment)
enabled_environments.nil? || enabled_environments.include?(environment)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a remark for now but eventually it would be good to have a more explicit interface for checking if a setting is disabled, something like config.enabled?(:enabled_environments) or something like this, because nil checks are bug prone.

@sl0thentr0py sl0thentr0py merged commit 519c24b into 6.0-dev Sep 23, 2025
138 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/enabled-environments-nil branch September 23, 2025 14:54
@sl0thentr0py sl0thentr0py mentioned this pull request Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants