Skip to content

Fix spec and remove redundant resques

a8c0433
Select commit
Loading
Failed to load commit list.
Merged

fix(logging): improve error handling in AR subscriber #2798

Fix spec and remove redundant resques
a8c0433
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 27, 2025 in 0s

88.66% (-1.46%) compared to fac9cc3

View this Pull Request on Codecov

88.66% (-1.46%) compared to fac9cc3

Details

Codecov Report

❌ Patch coverage is 33.33333% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.66%. Comparing base (fac9cc3) to head (a8c0433).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../rails/log_subscribers/active_record_subscriber.rb 23.07% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2798      +/-   ##
==========================================
- Coverage   90.12%   88.66%   -1.46%     
==========================================
  Files         132      126       -6     
  Lines        5296     5118     -178     
==========================================
- Hits         4773     4538     -235     
- Misses        523      580      +57     
Components Coverage Δ
sentry-ruby 96.64% <ø> (-0.62%) ⬇️
sentry-rails 41.66% <33.33%> (-13.66%) ⬇️
sentry-sidekiq 96.44% <ø> (+1.38%) ⬆️
sentry-resque 94.20% <ø> (-0.25%) ⬇️
sentry-delayed_job 95.65% <ø> (+0.97%) ⬆️
sentry-opentelemetry 99.31% <ø> (ø)
Files with missing lines Coverage Δ
sentry-rails/lib/sentry/rails/log_subscriber.rb 57.14% <100.00%> (+4.51%) ⬆️
.../rails/log_subscribers/active_record_subscriber.rb 24.32% <23.07%> (+1.03%) ⬆️

... and 52 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.