Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add feature for using surf with the h1-client #357

Merged
merged 1 commit into from
Aug 17, 2021
Merged

feat: add feature for using surf with the h1-client #357

merged 1 commit into from
Aug 17, 2021

Conversation

danielnelson
Copy link
Contributor

The current Cargo.toml enables default-features for surf which uses surf's curl-client. Since surf contains multiple client backends, the current feature set doesn't provide enough flexibility so that one can use the same HTTP client already in use in other parts of an application.

My project is using the h1-client from surf, and I would like to be able to use just a single HTTP client in my project. This pull request adds a new feature surf-h1 specifically to use surf with the h1-client.

It might be reasonable to also add additional features for surf so that the other clients can be enabled, here is a link to the client features in surf:
https://github.com/http-rs/surf/blob/1ffaba8873d49c672a45442bfd69ca53b81ea1cc/Cargo.toml#L24-L47

@codecov-commenter
Copy link

Codecov Report

Merging #357 (94c4793) into master (8909021) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #357   +/-   ##
=======================================
  Coverage   85.17%   85.17%           
=======================================
  Files          68       68           
  Lines        7398     7398           
=======================================
  Hits         6301     6301           
  Misses       1097     1097           

@Swatinem Swatinem merged commit 420444d into getsentry:master Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants