feat: add feature for using surf with the h1-client #357
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Cargo.toml enables default-features for surf which uses surf's curl-client. Since surf contains multiple client backends, the current feature set doesn't provide enough flexibility so that one can use the same HTTP client already in use in other parts of an application.
My project is using the h1-client from surf, and I would like to be able to use just a single HTTP client in my project. This pull request adds a new feature
surf-h1
specifically to use surf with the h1-client.It might be reasonable to also add additional features for surf so that the other clients can be enabled, here is a link to the client features in surf:
https://github.com/http-rs/surf/blob/1ffaba8873d49c672a45442bfd69ca53b81ea1cc/Cargo.toml#L24-L47