Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tokio an optional dependency for the transport feature #363

Merged
merged 2 commits into from
Sep 29, 2021

Conversation

Jasper-Bekkers
Copy link
Contributor

The tokio crate is quite a heavy dependency that we deny in our project through cargo deny, and it seems to be completely optional for sentry as well if we don't compile with the transport feature (which we don't - we provide our own transport layer).

This change make tokio optional for the non-dev dependencies saving on build times.

@Swatinem
Copy link
Member

It might be better to couple it to the reqwest/curl/surf features, in line with the mod declaration that pulls this in:

#[cfg(any(feature = "reqwest", feature = "curl", feature = "surf"))]
mod thread;

@Swatinem Swatinem merged commit e62cf33 into getsentry:master Sep 29, 2021
@Jasper-Bekkers Jasper-Bekkers changed the title Make an optional dependency for the transport feature Make tokio an optional dependency for the transport feature Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants