-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a Http Service integration with trace propagation (NATIVE-314) #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This creates a new sentry-tower feature that does trace propagation for Http Services.
Swatinem
force-pushed
the
feat/perf-http
branch
from
January 10, 2022 10:28
000da13
to
6a479ff
Compare
Codecov Report
@@ Coverage Diff @@
## master #397 +/- ##
=======================================
Coverage 81.86% 81.86%
=======================================
Files 70 70
Lines 7870 7870
=======================================
Hits 6443 6443
Misses 1427 1427 |
Swatinem
commented
Jan 10, 2022
flub
reviewed
Jan 11, 2022
flub
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #395, this creates a new sentry-tower feature, which enables a new tower
Layer
, which will start a new transaction for each Http request, using the incoming headers for distributed trace propagation.