Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Rewrite tracing integration in terms of manual API (NATIVE-312) #400

Merged
merged 3 commits into from
Jan 11, 2022

Conversation

Swatinem
Copy link
Member

@Swatinem Swatinem commented Jan 5, 2022

Instead of hand-rolling all the transaction/span manipulation, rather implement it on top of the manual performance monitoring API.

Base automatically changed from feat/performance to master January 10, 2022 10:14
Instead of hand-rolling all the transaction/span manipulation, rather
implement it on top of the manual performance monitoring API.
Currently lacks the ability to attach additional `data` to a span.
@Swatinem Swatinem marked this pull request as ready for review January 11, 2022 12:33
@codecov-commenter
Copy link

Codecov Report

Merging #400 (c0a6407) into master (afcac66) will increase coverage by 1.59%.
The diff coverage is 62.12%.

@@            Coverage Diff             @@
##           master     #400      +/-   ##
==========================================
+ Coverage   81.81%   83.40%   +1.59%     
==========================================
  Files          70       70              
  Lines        7878     7725     -153     
==========================================
- Hits         6445     6443       -2     
+ Misses       1433     1282     -151     

@Swatinem Swatinem merged commit df694a4 into master Jan 11, 2022
@Swatinem Swatinem deleted the ref/tracing-perf branch January 11, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants