Disable performance when client feature disabled #415
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
|
Oh well, that was a major oversight. This also means our test matrix is incomplete, as this should have been caught ideally. And I think we have to jump through the hoops and make sure the API at least exists and compiles even without the client, in case someone really wants to instrument their libraries with sentries perf API (though unlikely). |
|
I opened #416 instead which also correctly tests the feature flag in CI, and keeps the API around if the feature is not specified. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new performance features rely on the
clientfeature being enabled, and when it's not enabled sentry-core fails to compile, this just gates the entireperformancemodule behind theclientfeature for now so that it at least compiles, as it seemed non-trivial to untangle types likeTransactionOrSpanfromclient.