meta: Remove serde_json feature from curl
#420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Curl doesn't need `serde_json` support since Sentry already serializes envelopes to a vector of bytes internally. Likewise no other transport sets the `Content-Type: application/json` header, presumably because the data is multiple json objects concatenated together.
flub
approved these changes
Jan 28, 2022
Codecov Report
@@ Coverage Diff @@
## master #420 +/- ##
==========================================
+ Coverage 81.68% 81.70% +0.02%
==========================================
Files 71 71
Lines 8092 8091 -1
==========================================
+ Hits 6610 6611 +1
+ Misses 1482 1480 -2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Curl doesn't need
serde_jsonsupport since Sentry already serializes envelopes to a vector of bytes internally. Likewise no other transport sets theContent-Type: application/jsonheader, presumably because the data is multiple json objects concatenated together.