ref: Forward set_transaction to a running Transaction #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #433 +/- ##
==========================================
+ Coverage 80.48% 80.53% +0.04%
==========================================
Files 73 73
Lines 8252 8288 +36
==========================================
+ Hits 6642 6675 +33
- Misses 1610 1613 +3 |
flub
approved these changes
Feb 14, 2022
| @@ -160,6 +160,17 @@ impl Scope { | |||
| /// Sets the transaction. | |||
| pub fn set_transaction(&mut self, transaction: Option<&str>) { | |||
| self.transaction = transaction.map(Arc::from); | |||
| if let Some(name) = transaction { | |||
There was a problem hiding this comment.
nit: if you're switching to if let i think it makes more sense to move line 162 into this block as well to keep the logic the same which make reading easier.
There was a problem hiding this comment.
The line above should explicitly set None as well though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A call to
Scope::set_transactionwill now also forward the given name to the currently running performance monitoring transaction to override thenameit was started with.