sentry-core: add public getters for TransactionContext #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #514 +/- ##
=======================================
Coverage 78.76% 78.76%
=======================================
Files 76 76
Lines 9240 9269 +29
=======================================
+ Hits 7278 7301 +23
- Misses 1962 1968 +6 |
loewenheim
approved these changes
Nov 7, 2022
|
@loewenheim is there anything blocking from this getting merged and released? not sure about the process to move this forward :) |
|
Not at all, I think master just needs to be merged into it :) |
|
@loewenheim can we help with the release in some way? :) |
|
Just started the ball rolling :) |
|
awesome, thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #512, to enable support for
traces_samplerinspecting first class properties ofTransactionContext.This was split as we though the addition of
CustomTransactionContextmay require further discussion, while these changes should be uncontroversial.ref: #512 (comment)