-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tracing): Add method for accessing span data #548
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #548 +/- ##
==========================================
- Coverage 70.68% 70.59% -0.10%
==========================================
Files 66 66
Lines 6649 6658 +9
==========================================
Hits 4700 4700
- Misses 1949 1958 +9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m not entirely sure if we call out locking explicitly in other parts of the SDK, but it might be good to at least mention it, as otherwise this is a footgun that could lead to deadlocks.
Yeah, I was wondering about this as well. I'll add a note. |
Another idea would be to take a |
This adds a
data
method toperformance::Span
that gives exclusive access to the underlyingprotocol::Span
'sdata
field (a map fromString
toprotocol::Value
). Since the inner span is behind aMutex
, thedata
method returns aData
smart pointer that holds the lock.