fix: Don't block on sending envelopes (ureq/curl transports) #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjenvey
force-pushed
the
fix/thread-transport-dont-block
branch
from
e4b5636
to
6648b7c
Compare
Swatinem
approved these changes
Oct 24, 2024
viglia
approved these changes
Oct 24, 2024
pjenvey
added a commit
to mozilla-services/syncstorage-rs
that referenced
this pull request
Oct 29, 2024
includes the fix: getsentry/sentry-rust#701 Closes SYNC-4460
pjenvey
added a commit
to mozilla-services/syncstorage-rs
that referenced
this pull request
Oct 29, 2024
includes the fix: getsentry/sentry-rust#701 Closes SYNC-4460
pjenvey
added a commit
to mozilla-services/syncstorage-rs
that referenced
this pull request
Oct 29, 2024
includes the fix: getsentry/sentry-rust#701 Closes SYNC-4460
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #546 (for #543):
Any transport is susceptible to #543, where sending too many events (or even potentially due to network hiccups) to Sentry can block. So the
thread::TransportThreadimpl should similarly drop events instead of blocking, just as the similartokio_thread::TransportThreadbegan doing with the fix in #546.