Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve parameterization of transaction names #649

Closed
smeubank opened this issue Aug 1, 2022 · 4 comments · Fixed by #692
Closed

Improve parameterization of transaction names #649

smeubank opened this issue Aug 1, 2022 · 4 comments · Fixed by #692
Assignees
@stayallive @cleptric
Milestone
4.6.0

Comments

@smeubank
Copy link
Member

smeubank commented Aug 1, 2022

Environment

How do you use Sentry?
Sentry SaaS (sentry.io)

Which SDK and version?
sentry-symfony

Steps to Reproduce

similar to getsentry/sentry-laravel#562

Expected Result

Parameterized transactions as often as possible

Actual Result

seems symfony only sends raw URLs for everything
@smeubank
Copy link
Member Author

smeubank commented Aug 4, 2022

we should open a convo with Symfony that they add something to help us access their routing properly

@github-actions

This comment was marked as outdated.

Sign in to view
@cleptric cleptric mentioned this issue Oct 10, 2022
Merged
@cleptric cleptric self-assigned this Oct 10, 2022
@cleptric cleptric added this to the 4.4 milestone Oct 10, 2022
@cleptric cleptric modified the milestones: 4.4, 5.0 Oct 11, 2022
@github-actions

This comment was marked as outdated.

Sign in to view
@cleptric
Copy link
Member

So after speaking with various folks during SymfonyCon, we'll likely use the route name as the default source for transaction names. While the _controller property could also be an option, there is the use case of https://symfony.com/doc/4.1/templating/render_without_controller.html which ends up being not very useful.

See #547 for a former discussion

@cleptric cleptric mentioned this issue Nov 21, 2022
Closed
@cleptric cleptric modified the milestones: 5.0, 4.5, 4.5.0, 4.6.0 Nov 21, 2022
@cleptric cleptric mentioned this issue Feb 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stayallive stayallive

@cleptric cleptric

Labels
None yet
Projects
None yet
Milestone
4.6.0
Development

Successfully merging a pull request may close this issue.

ref: Use _route as the transaction name getsentry/sentry-symfony
4 participants
@stayallive @cleptric @stephanie-anderson @smeubank