Symfony 7 support

[Jean85]

This is a playground to act upon symfony/symfony#51563

Symfony 7 is coming this November, and it will include a type overhaul that will impact the ecosystem, and us too.

In this PR, I tried forcibly upgrading to it, and 968b232 lists all the changes that we need to do; I'll comment them accordingly.

Unfortunately, at least the cache adapters require a mixed return type, which is a breaking change. We would need to either duplicate and selectively autoload those classes (as we already did with DBAL v2 vs v3) or do a breaking change, requiring PHP 8.0 as a minimum.

[stof]

what is the goal of this Force Symfony 6.4-dev commit ?

[ste93cry]

I don't know, but I reverted the changes and added Symfony 7.* to the test matrix

[javiereguiluz]

About this concern from the original PR description:

"Unfortunately, at least the cache adapters require a mixed return type, which is a breaking change. We would need to either [...] or do a breaking change, requiring PHP 8.0 as a minimum."

FYI, active support for PHP 8.0 ended a year ago and security support will end in 19 days. Also, active support for PHP 8.1 ends in 18 days. See https://www.php.net/supported-versions.php

So, it's probably OK to change the PHP requirements. Thanks!

[cleptric]

No, it's not ok to raise the PHP requirement 🙂

~17% of our users are still below PHP 8.0 https://packagist.org/packages/sentry/sentry-symfony/php-stats#4.

[janklan]

~17% of our users are still below PHP 8.0

Isn't a new major version release a solution to introducing bc breaks? Why not release a 5.x and let the sloths be sloths?

[cleptric]

~17% of our users are still below PHP 8.0

Isn't a new major version release a solution to introducing bc breaks? Why not release a 5.x and let the sloths be sloths?

Because this is not how Sentry operates, have a look at https://develop.sentry.dev/sdk/philosophy/#compatibility-is-king.

[janklan]

Because this is not how Sentry operates, have a look at https://develop.sentry.dev/sdk/philosophy/#compatibility-is-king.

Yeah, I get that, but releasing a new major version with breaking changes doesn't prevent anyone from maintaining the 4.x branch with legacy code support.

Either way, I assume you guys will work something out to support Symfony 7. Compatibility is king, like you said.

[janklan]

You're on fire, @ste93cry! 🤘

[Jean85]

We're getting failures due to deprecations on a --prefer-lowest job, maybe we should silence deprecations in that case?

[ste93cry]

we should silence deprecations in that case?

There's no need to, I reinstated the dependency on the symfony/dom-crawler package that I removed earlier, without realizing that it was required explicitly to avoid those deprecations. Changes look good now, CI is finally 🟢, so LGTM for me

[cleptric]

Thanks @Jean85 & @ste93cry!