Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a flag whether to ignore the CLI errors during Android symbol upload #1687

Merged
merged 5 commits into from
Jun 10, 2024

Conversation

munkiki7
Copy link
Contributor

@munkiki7 munkiki7 commented Jun 10, 2024

Added a IgnoreCliErrors flag to Sentry CLI Options, that will wrap the symbol and mapping upload Gradle tasks in try/catch blocks if it is toggled, so if they fail, the Unity build will still succeed. It is disabled by default.

Copy link
Contributor

github-actions bot commented Jun 10, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against cd1959f

@munkiki7 munkiki7 marked this pull request as ready for review June 10, 2024 14:11
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@bitsandfoxes bitsandfoxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@bitsandfoxes bitsandfoxes merged commit 60065fb into main Jun 10, 2024
3 checks passed
@bitsandfoxes bitsandfoxes deleted the feat/add-ignore-cli-errors-flag branch June 10, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants