test: packaging with validation #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-garcia
force-pushed
the
fix/packaging-with-validation
branch
from
2ea258e to
1047b78
Compare
bruno-garcia
changed the title
bruno-garcia
commented
Nov 29, 2021
scripts/pack.ps1
Outdated
| @@ -1,3 +1,4 @@ | |||
| Remove-Item "package-release" -Recurse | |||
There was a problem hiding this comment.
Makes the script reentrant
|
Works: I mean fails, because in CI we have alias'ed stuff. Just need to update the snapshot and profit |
bitsandfoxes
approved these changes
Nov 30, 2021
| # Verifies the contents of the UPM package against a snapshot file | ||
| # 'dotnet build' and 'pack.ps1' must have already been run | ||
|
|
||
| # To accept a new snapshot file, run 'pwsh ./test.ps1 accept' |
There was a problem hiding this comment.
Suggested change
| # To accept a new snapshot file, run 'pwsh ./test.ps1 accept' | |
| # To accept a new snapshot file, run 'pwsh ./test/Scripts.Tests/test-pack-contents.ps1 accept' |
There was a problem hiding this comment.
The path is below this line so I avoided a copy paste here
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing will show what's missing and what's extra:
#skip-changelog
Partially resolves #431