Add support for @sentry/cli v2

[taylorc93]

Based on #362, it looks like this package supports the new major v2 release of @sentry/cli. However, it's still configured to only support v1 in the package.json. This is causing multiple versions of @sentry/cli to be installed in my project. This is a quick fix to allow the v2 version to satisfy the dependency and ensure that projects on the most up to date version don't install multiple versions.

Please let me know if there is anything else you need me to do here to get this merged!

[kamilogorek]

This change will make npm and yarn to install latest version of @sentry/cli, which is not compatible with node <12, thus breaking the installation for users of this plugins current major version.

cc @gsouf @AbhiPrasad

[gsouf]

@kamilogorek would it even though it's requiring one of v1 or v2 (ie "@sentry/cli": "^1.74.4 || ^2.0.0")?

Also node v8 is strongly outdated (https://github.com/nodejs/release#release-schedule) and many vendors have already moved to support node12 or newer as minimal node version and as you said sentry-cli itself is requiring newer version. Would that be a problem to upgrade so that all sentry tools are inlined on the same version of things?

[AbhiPrasad]

Also node v8 is strongly outdated (https://github.com/nodejs/release#release-schedule) and many vendors have already moved to support node12 or newer as minimal node version

Great point - but at Sentry we aim to be as backwards compatible as possible. See: https://develop.sentry.dev/sdk/philosophy/#compatibility-is-king. Maybe it's fair to just drop Node support for the bundlers though.

[gsouf]

Tested the following: "@sentry/cli": "^1.74.4 || ^2.0.0" using node 8

Yarn throws this error: error @sentry/cli@2.5.2: The engine "node" is incompatible with this module. Expected version ">= 12". Got "8.17.0"

npm installs @sentry/cli v2.x without complaining.

So indeed package managers are not resolving package version based on the system node version/package's engine.

---

With that said I was wondering if that would be possible to bump a new major (or minor? see bellow) version of this webpack plugin using the proposed version range ("@sentry/cli": "^1.74.4 || ^2.0.0") and whoever can't use v2.x of sentrly/cli would need to manually add ``"@sentry/cli": "^1.74.4"` in their own package.json.

That's a bit more of setup for people with node<12 but (without entering into a debate whether it's good or not to have outdated stuff) I believe that whoever is keeping their software stack up to date shouldn't have to pay for who is staying with old software.

---

Side note - I have seen a few times the question of whether a dependency change should come with a major version bump - the question has generally been answered as "no" as their is no change in your public api

[kamilogorek]

@kamilogorek would it even though it's requiring one of v1 or v2 (ie "@sentry/cli": "^1.74.4 || ^2.0.0")?

Unfortunatelly yes.

{
  "name": "tmp",
  "version": "1.0.0",
  "main": "index.js",
  "license": "MIT",
  "dependencies": {
    "@sentry/cli": "^1.74.5 || ^2.0.0"
  }
}

You can store it as package.json and run yarn or npm install on multiple node versions, and it always picks up latest.

[kamilogorek]

Side note - I have seen a few times the question of whether a dependency change should come with a major version bump - the question has generally been answered as "no" as their is no change in your public api

That is true, as long as the dependency won't break the build, which in this case it does :(

[simPod]

Is there anything we can do to get this merged?

---

Old sentry/cli gives me spawn ETXTBSY error but I don't want to file a bug since new major already exists.

➤ YN0000: │ @sentry/cli@npm:1.74.6 STDERR info sentry-cli Downloading from https://downloads.sentry-cdn.com/sentry-cli/1.74.6/sentry-cli-Linux-x86_64
➤ YN0000: │ @sentry/cli@npm:1.74.6 STDERR info Checksum validation passed. 
➤ YN0000: │ @sentry/cli@npm:1.74.6 STDERR Error: spawn ETXTBSY

[lforst]

We moved to @sentry/cli v2 with release 2.0.0: https://github.com/getsentry/sentry-javascript-bundler-plugins/releases/tag/2.0.0