The setup wizard fails when used with pnpm and workspaces

[drazisil-codecov]

Environment

SaaS (https://sentry.io/)

Steps to Reproduce

1. Create a monorepo with pnpm
2. Run Sentry wizard
3. Select pnpm

Expected Result

Sentry wizard is able to complete setup

Actual Result

pnpm add command fails due to missing -w flag to allow for top-level install

Product Area

Unknown

Link

No response

DSN

No response

Version

No response

[getsantry]

Assigning to @getsentry/support for routing ⏲️

[getsantry]

Routing to @getsentry/product-owners-projects-project-creation for triage ⏲️

[lforst]

Generally speaking, the wizard shouldn't be ran in the root of a workspace - I guess this is a docs issue we need to resolve.

[michael-ravelhq]

Generally speaking, the wizard shouldn't be ran in the root of a workspace - I guess this is a docs issue we need to resolve.

@lforst - It doesn't only fail when running in the root of the project.
I have a monorepo using turborepo. my node api server has dependencies in the workspace.

I am getting the following error:

│  Error: Command failed: npm add @sentry/esbuild-plugin
│  npm ERR! code EUNSUPPORTEDPROTOCOL
│  npm ERR! Unsupported URL Type "workspace:": workspace:*

This is probably caused by the wizard using npm instead of pnpm.

[lforst]

@michael-ravelhq Did the wizard not ask you which package manager you are using?

[michael-ravelhq]

No. I ran it using `pnpm dlx`. On 22 Apr 2024, at 12:30, Luca Forstner ***@***.***> wrote: @michael-ravelhq Did the wizard not ask you which package manager you are using? —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

[andrewchen30]

I think we enocunter the same issue

[Lms24]

@michael-ravelhq the wizard looks at lock files to determine which package manager to use. Any chance that you have a package-lock.json floating around that the wizard could pick up instead of the pnpm-lock.yaml?

@andrewchen30 can you re-run the wizard with the --debug argument? I think this might reveal some additional error logs that could help here

[andrewchen30]

No information even if we use --debug

BTW, I manually installed the @sentry/nextjs@^8 package to fix the issue. Our senty work properly for now. I guess it's fine for us right now.

Thanks for the quick reply!!

[Lms24]

Oh I see. But yeah it's probably the same cause.

Did you run the wizard in the root of your monorepo or in the package where the SDK should be installed? We generally recommend running it in the project directory.

[andrewchen30]

Oh I see. But yeah it's probably the same cause.

Did you run the wizard in the root of your monorepo or in the package where the SDK should be installed? We generally recommend running it in the project directory.

No, I runned it on the project-directory level. I am also wondering why it happened, might be some pnpm setupj confused the wizard.

[lforst]

@andrewchen30 @michael-ravelhq We have just released a new version of the wizard that will be a bit more sensible in workspace roots and also emit a log file when the installation command goes wrong. Feel free to try it out, and if it continues failing it would be cool if you could share the logfile with us. Thanks!

[drazisil-codecov]

Sorry, didn't mean to kick it back, I was pinging myself a reminder.

[andrewchen30]

@andrewchen30 @michael-ravelhq We have just released a new version of the wizard that will be a bit more sensible in workspace roots and also emit a log file when the installation command goes wrong. Feel free to try it out, and if it continues failing it would be cool if you could share the logfile with us. Thanks!

Just tested, it's fixed!!! Thanks a lot!

[lforst]

@andrewchen30 awesome, thanks for checking, closing this issue then. If there continue to be problems with this issue let us know.