Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve error logging for package installation #635

Merged
merged 2 commits into from
Aug 1, 2024
Merged

feat: Improve error logging for package installation #635

merged 2 commits into from
Aug 1, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented Aug 1, 2024 •
edited
Loading

  • Emits a .log file when package installation fails
  • Updates the resulting log message to instruct the user to include the log file in the issue
  • Adds flags to the package manager commands to ignore potential errors when running the wizard in the workspace root (noticed this to be an issue in our docs repo for example)

Relates to #553

@lforst lforst requested a review from Lms24 August 1, 2024 12:29
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2024 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 8fed2a7

@lforst lforst merged commit 5febecc into master Aug 1, 2024
13 checks passed
@lforst lforst deleted the lforst-better-log-messages branch August 1, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lforst @Lms24