Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(apple): Don't remove other swift packages #396

Merged
merged 2 commits into from
Aug 4, 2023
Merged

fix(apple): Don't remove other swift packages #396

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
febf340
fix(apple): Don't remove other swift packages
brustolin Aug 4, 2023
4a4745c
Update CHANGELOG.md
brustolin Aug 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions .vscode/launch.json
View file
Open in desktop
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file were never meant to be sent to the repo.

This file was deleted.

9 changes: 7 additions & 2 deletions src/apple/xcode-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,10 @@ function addSentrySPM(proj: any): void {
comment: 'XCRemoteSwiftPackageReference "sentry-cocoa"',
});

xcObjects.XCRemoteSwiftPackageReference = {};
if (!xcObjects.XCRemoteSwiftPackageReference) {
xcObjects.XCRemoteSwiftPackageReference = {};
}

xcObjects.XCRemoteSwiftPackageReference[sentrySwiftPackageUUID] = {
isa: 'XCRemoteSwiftPackageReference',
repositoryURL: '"https://github.com/getsentry/sentry-cocoa/"',
Expand All @@ -92,7 +95,9 @@ function addSentrySPM(proj: any): void {
xcObjects.XCRemoteSwiftPackageReference[sentrySwiftPackageUUID + '_comment'] =
'XCRemoteSwiftPackageReference "sentry-cocoa"';

xcObjects.XCSwiftPackageProductDependency = {};
if (!xcObjects.XCSwiftPackageProductDependency) {
xcObjects.XCSwiftPackageProductDependency = {};
}
xcObjects.XCSwiftPackageProductDependency[sentrySPMUUID] = {
isa: 'XCSwiftPackageProductDependency',
package: sentrySwiftPackageUUID,
Expand Down
Loading