Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sentry-cli-sourcemaps): Fix writing of build command #398

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

lforst
Copy link
Member

@lforst lforst commented Aug 11, 2023

In the case when the user has a script called build we would take its value instead of its key as the name of the build command - which is, as you would have guessed it, not right.

@lforst lforst requested a review from Lms24 August 11, 2023 11:14
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh damn... good catch!

@lforst lforst merged commit 882fc66 into master Aug 11, 2023
9 checks passed
@lforst lforst deleted the lforst-fix-setting-of-build-command branch August 11, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants