Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(sveltekit): Improve outro message #514

Merged
merged 3 commits into from
Dec 14, 2023
Merged

ref(sveltekit): Improve outro message #514

merged 3 commits into from
Dec 14, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Dec 12, 2023 •
edited
Loading

Inspired by #513 and #480, this PR improves the SvelteKit wizard outro message:

  • restart instead of start
  • use cyan more sparingly
  • dynamically adjust command based on detected package manager

@Lms24 Lms24 requested review from lforst and AbhiPrasad December 12, 2023 15:08
@Lms24 Lms24 merged commit 556f734 into master Dec 14, 2023
2 of 3 checks passed
@Lms24 Lms24 deleted the lms/ref-sveltekit-improve-outro-msg branch December 14, 2023 12:07
@github-actions GitHub Actions
Copy link

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Improve outro message ([#514](https://github.com/getsentry/sentry-wizard/pull/514))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 2d16b95

@Lms24 Lms24 mentioned this pull request Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@lforst lforst Awaiting requested review from lforst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lms24 @AbhiPrasad