feat(Next.js): Added Spotlight option in server config #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shubhdeep12
changed the title
lforst
reviewed
Mar 7, 2024
src/nextjs/templates.ts
Outdated
Comment on lines
163
to
165
| debug: false, | ||
| ${additionalOptions} | ||
| ${spotlightOption} |
There was a problem hiding this comment.
Looking at this change superficially I think this will mess up the output.
There was a problem hiding this comment.
Hi @lforst this was adding some extra empty lines, which I just fixed.
Is there any specific issue that you are mentioning here? which I am missing?
There was a problem hiding this comment.
That was what I was referring to. Thanks for fixing it!
lforst
approved these changes
Mar 7, 2024
|
Hi, prettier is failing and also could you add a changelog entry? Thanks! |
Hi @lforst it should be fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added comment to add spotlight in Sentry.init for next.js server config
Note: We did not include the installation and setup of Spotlight because it is not added by default, and it is also not mandatory.
#535