feat(SvelteKit): Added Spotlight option in server config #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Thanks! So there's a second part to this but I'm afraid it's not super trivial. We only add the Sentry.init call from templates.ts if there's no prior hooks.server.ts file. In case there is, we try and add our Sentry code to the existing code using AST manipulation.
I briefly tried adding a comment into the init call options object but it completely messed up file formatting. So for now, let's just go with this in the template. We can revisit this later.
Long term, I'd like to streamline of our AST manipulation tools and remove magicast in favour of directly using recast. This should give us more freedom to make such changes ideally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added comment to add spotlight in Sentry.init for svelteKit server hooks config
Note: We did not include the installation and setup of Spotlight because it is not added by default, and it is also not mandatory.
#535