Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(check-sdk-version): add @sentry/nestjs to sentry sdk packages #676

Merged
merged 4 commits into from
Sep 23, 2024
Merged

fix(check-sdk-version): add @sentry/nestjs to sentry sdk packages #676

merged 4 commits into from
Sep 23, 2024

Conversation

obostjancic
Copy link
Member

@obostjancic obostjancic requested a review from Lms24 September 23, 2024 14:03
obostjancic
obostjancic commented Sep 23, 2024
View reviewed changes
Copy link
Member Author

@obostjancic obostjancic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lms24 are there any other SDKs that might be missing from this list. Like @sentry/astro?

Lms24
Lms24 approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof yeah, good point! This list is pretty stale 😬

This is correct for sure but there are some more missing ones

  • @sentry/astro
  • @sentry/solid
  • @sentry/nuxt
  • @sentry/solidStart
  • @sentry/deno
  • @sentry/bun
  • @sentry/aws-serverless
  • @sentry/google-cloud-serverless

If you want I can also open a follow-up PR and add them in the correct order (but feel free to do it yourself in this PR, whatever you prefer!)

@obostjancic
Copy link
Member Author

@Lms24 I'll update this PR :D

Lms24
Lms24 approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating!

src/sourcemaps/utils/sdk-version.ts Outdated Show resolved Hide resolved
@obostjancic obostjancic merged commit a893cd7 into master Sep 23, 2024
13 checks passed
@obostjancic obostjancic deleted the ogi/fix/nestjs-sdk-detection branch September 23, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wizard: Ensure that sentry SDK is correctly identified
2 participants
@obostjancic @Lms24