feat(nuxt): Add Nuxt menu option and install SDK #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lforst
previously requested changes
Nov 14, 2024
|
@lforst merge target is an "epic" branch. |
Lms24
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Nice work so far! I ran the wizard and things look good. I think it's okay to merge this into the epic branch.
One nit (feel free to do in this PR or in a separate one): I think this is not on you but can we make the filename in red be coloured in cyan? Just for consistency...
|
@Lms24 updated to cyan |
andreiborza
added a commit
that referenced
this pull request
Nov 25, 2024
* feat(nuxt): Add Nuxt menu option and install SDK * Mark sentry dot env file in cyan color
andreiborza
added a commit
that referenced
this pull request
Nov 27, 2024
* feat(nuxt): Add Nuxt menu option and install SDK (#711) * feat(nuxt): Add Nuxt menu option and install SDK * Mark sentry dot env file in cyan color * feat(nuxt): Add sdk module to nuxt config and create client and server config files (#713) * feat(nuxt): Add sdk module to nuxt config and create client and server config files * Log snippets when user denies overwriting their configs * feat(nuxt): Add example page/component creation and final messaging (#717) * feat(nuxt): Add nuxt 3 and 4 e2e test apps (#718) * feat(nuxt): Add nuxt-3 e2e tests * Add nuxt-3 e2e tests * Add describe level * Add nuxt-4 e2e test app * Add nuxt 4 e2e test app * Remove leaking test helper * change client source map to hidden * add scoped styles * Add fallback in case magicast can't parse/modify the nuxt config * change min version to 3.7.0 * Update src/nuxt/sdk-setup.ts Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io> --------- Co-authored-by: s1gr1d <sigrid.huemer@posteo.at> Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested locally with a Nuxt app. Will add tests and e2e tests #710.
#skip-changelog
Closes: #706