feat: Pin JS SDK versions to v8 #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@andreiborza Reminder to maybe also do this for Nuxt/Solid when this is merged. |
Lms24
approved these changes
Nov 15, 2024
Comment on lines
+6
to
+14
| "overrides": [ | ||
| { | ||
| "files": "CHANGELOG.md", | ||
| "options": { | ||
| "proseWrap": "preserve" | ||
| } | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
just to confirm: Is this on purpose? No objections btw
There was a problem hiding this comment.
Yeah, I got annoyed by prettier fully re-formatting the changelog when formatting-on-save. This causes there to not be any changes anymore!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pins the installed SDK versions to v8 so we can safely release v9 without running into any compatibility issues.
We are adding a label option to the installPackage util to prevent any ugly log messages.
Closes #704