!remove(react-native): Uninstall command #983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #983 +/- ##
==========================================
- Coverage 27.73% 27.53% -0.20%
==========================================
Files 130 129 -1
Lines 14370 14093 -277
Branches 860 835 -25
==========================================
- Hits 3985 3881 -104
+ Misses 10367 10194 -173
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
krystofwoldrich
force-pushed
the
kw-remove-rn-uninstall
branch
from
364070c to
ba032e4
Compare
krystofwoldrich
changed the title
krystofwoldrich
force-pushed
the
kw-remove-rn-uninstall
branch
from
ba032e4 to
6265bba
Compare
philprime
reviewed
May 5, 2025
Member
philprime
left a comment
philprime
left a comment
There was a problem hiding this comment.
I agree with removing this in the next major. Not sure what the procedure here is, therefore only commenting and not approving.
antonis
reviewed
May 6, 2025
Contributor
antonis
left a comment
antonis
left a comment
There was a problem hiding this comment.
The changes on this PR LGTM and removing the uninstall functionality makes sense to me 👍
Happy to approved when we are ready to merge this 🙏
Lms24
reviewed
May 6, 2025
Member
There was a problem hiding this comment.
Thanks for making this change! I Fully agree with it. Let's cut a wizard major for this just to be on the safe side. Luckily, this is very straight forward:
- please add a sentence in the changelog mentioning the breaking changes in a dedicated section
- let's add a
!to the PR and commit message to point this out clearly (soremove(react-native)!)
We want to cut an SDK release today since there already a few pending changes. Let's merge this after that release so that the major itself is as small as possible.
krystofwoldrich
changed the title
krystofwoldrich
force-pushed
the
kw-remove-rn-uninstall
branch
from
6265bba to
11d2f80
Compare
Contributor
Author
|
@Lms24 I've updated the changelog, this is ready for ✅. |
6 tasks
antonis
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Nov 5, 2025
<!-- Use this checklist to make sure your PR is ready for merge. You may delete any sections you don't need. --> ## DESCRIBE YOUR PR *Tell us what you're changing and why. If your PR **resolves an issue**, please link it so it closes automatically.* Removed the uninstall doc from React Native since the functionality was removed a while ago with getsentry/sentry-wizard#983 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [ ] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## LEGAL BOILERPLATE <!-- Sentry employees and contractors can delete or ignore this section. --> Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The uninstall command is not up to date and it's technically not possible to automatically remove all Sentry code from the project code base safely.
For similar reasons none of other wizard have uninstall functionality.
This is a breaking change. Should go out with RN SDK V7.